Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add BigQuery source and Prefect tasks #1035

Open
wants to merge 24 commits into
base: 2.0
Choose a base branch
from
Open

✨ Add BigQuery source and Prefect tasks #1035

wants to merge 24 commits into from
+783 −2

Conversation

Diego-H-S
Copy link
Contributor

Summary

BigQuery connector migration from viadot 1 to viadot 2.

issue: #910

Importance

Required by the migration project.

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@Diego-H-S Diego-H-S mentioned this pull request Sep 17, 2024
Open
6 tasks
trymzet
trymzet requested changes Sep 18, 2024
View reviewed changes
src/viadot/orchestration/prefect/flows/__init__.py Outdated Show resolved Hide resolved
src/viadot/orchestration/prefect/flows/bigquery_to_adls.py Outdated Show resolved Hide resolved
src/viadot/orchestration/prefect/flows/bigquery_to_adls.py Outdated Show resolved Hide resolved
src/viadot/orchestration/prefect/tasks/bigquery.py Outdated Show resolved Hide resolved
src/viadot/sources/bigquery.py Outdated Show resolved Hide resolved
src/viadot/sources/bigquery.py Outdated Show resolved Hide resolved
src/viadot/sources/bigquery.py Show resolved Hide resolved
src/viadot/sources/bigquery.py Outdated Show resolved Hide resolved
src/viadot/sources/bigquery.py Outdated Show resolved Hide resolved
src/viadot/sources/bigquery.py Outdated Show resolved Hide resolved
Diego-H-S
Diego-H-S commented Sep 19, 2024
View reviewed changes
Copy link
Contributor Author

@Diego-H-S Diego-H-S left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at the responses.

trymzet
trymzet requested changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@trymzet trymzet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing left with the api_connection() method, otherwise pls create an issue to track the rest and link it in relevant conversations so I can close them, and then we can merge.

@trymzet
Copy link
Contributor

trymzet commented Sep 25, 2024 •
edited
Loading

@angelika233 can you rebase pls, and make sure that checks pass? Otherwise, seems like this is good to go.

@mgardzinski mgardzinski force-pushed the bigquery_2.0 branch 3 times, most recently from ea10e2a to f08ff76 Compare September 26, 2024 14:36
@trymzet trymzet changed the title Bigquery 2.0 ✨ Add BigQuery source and Prefect tasks Sep 27, 2024
@trymzet trymzet mentioned this pull request Sep 27, 2024
Closed
5 tasks
@mgardzinski mgardzinski self-requested a review September 27, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trymzet trymzet Awaiting requested review from trymzet

@mgardzinski mgardzinski Awaiting requested review from mgardzinski

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Diego-H-S @trymzet @mgardzinski @fdelgadodyvenia